Repository navigation
Time the copy passes under VerboseLog; narrow their read barrier - #11
Merged
Merged
Conversation
With [Debug] VerboseLog=1 each CopyPass writes a BOTTOM_OF_PIPE timestamp pair around its copy (4-frame ring, read back without waiting before reuse), and every 600 frames the log shows the average and max GPU time per pass and their total against the frame time. No query pool exists when VerboseLog is off. The barrier after each copy now waits for COMPUTE_SHADER | TRANSFER (where DLSS-G reads the copies) instead of ALL_COMMANDS, so the game's following graphics work doesn't wait for the dispatch. Measured at 6x on an RTX 5090 (1080p DLSS Quality, parallel mode): depth ~12.8 us, motion vectors ~10.6 us, HUD-less ~20.7 us, ~44 us total, about 0.5% of the frame. Also restores the "Key risks" heading in docs/DEVELOPMENT.md that the queue-parallelism entry dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
[Debug] VerboseLog=1only):CopyPass(depth, motion vectors, HUD-less) writes aBOTTOM_OF_PIPEtimestamp pair around its copy, in a 4-frame ring. A pair is read back withvkGetQueryPoolResults(no WAIT, so a result that isn't ready is skipped) just before its queries are reused.copy passes GPU time: depth … mvec … hudless …; total … us per frame (frame … ms).COMPUTE_SHADER | TRANSFERas its destination stage, where DLSS-G reads the copies, instead ofALL_COMMANDS. The game's following graphics work no longer waits for our dispatch.[Unreleased]entry.## Key risksheading that Run DLSS-G with queue parallelism by default #9 accidentally dropped.tools/README.txtnote.Testing
GPU and driver: RTX 5090, driver 616.92, 1080p DLSS Quality, parallel mode
Multipliers tested: 6x for about 90 s with
VerboseLog=1; 15 full 600-frame timing windows, 0 fence timeouts.The max values of 200–2,100 µs are measurement artifacts from GPU work in between the two timestamps, such as DLSS-G on its own queues. They hit all three passes at random, while the averages stay flat. The barrier change is too small to show in fps.
## [Unreleased]in CHANGELOG.md🤖 Generated with Claude Code